Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unquoted property names with dashes #83

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

akudev
Copy link
Contributor

@akudev akudev commented Oct 16, 2023

The existing syntax is invalid. Dashes outside strings are considered "minus" characters.

Please look for other places.

@cla-assistant
Copy link

cla-assistant bot commented Oct 16, 2023

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Oct 16, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@OlMue
Copy link
Contributor

OlMue commented Oct 16, 2023

Thanks, @akudev! @KvM2, let's check how we can look for other instances of this.

@akudev
Copy link
Contributor Author

akudev commented Oct 16, 2023

Actually it seems to be the only instance of this problem in this repo: https://github.com/search?q=repo%3ASAP-docs%2Fsapui5+%2F%5E%5Cs%2B%5Cw%2B-%5Ba-zA-Z0-9-%5D*%3A%5Cs*%22%2F&type=code

@KvM2
Copy link
Contributor

KvM2 commented Nov 16, 2023

Hi @akudev, Thanks for your contribution. I have adapted the documentation for 1.120.

@KvM2 KvM2 merged commit 419ea72 into SAP-docs:main Nov 16, 2023
3 checks passed
@sap-doc-bot sap-doc-bot bot added the contribution Valuable Contribution label Nov 16, 2023
Copy link

sap-doc-bot bot commented Nov 16, 2023

Thank you for your valuable content contribution, @akudev! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

@akudev
Copy link
Contributor Author

akudev commented Nov 16, 2023

@qmacro qmacro added the mission-award SAP Community mission award label Nov 18, 2023
@OlMue OlMue added the type/content-gaps Something essential is missing in the documentation. label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution mission-award SAP Community mission award type/content-gaps Something essential is missing in the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants